Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Remove outdated TODO #5956

Merged
merged 1 commit into from
Aug 30, 2022
Merged

[core] Remove outdated TODO #5956

merged 1 commit into from
Aug 30, 2022

Conversation

flaviendelangle
Copy link
Member

The behavior described in the TODO has already been implemented (see lines below the removed comment)

@flaviendelangle flaviendelangle added core Infrastructure work going on behind the scenes component: pickers This is the name of the generic UI component, not the React module! labels Aug 30, 2022
@flaviendelangle flaviendelangle self-assigned this Aug 30, 2022
@mui-bot
Copy link

mui-bot commented Aug 30, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 336.9 569 416.2 444.64 100.783
Sort 100k rows ms 490.3 872.7 782.4 745.78 132.495
Select 100k rows ms 132.7 307.2 205.7 213.6 55.703
Deselect 100k rows ms 143.4 351.2 193.2 231.46 82.205

Generated by 🚫 dangerJS against 47ff7e2

@flaviendelangle flaviendelangle merged commit 4de175c into mui:master Aug 30, 2022
@flaviendelangle flaviendelangle deleted the useless-todo branch August 30, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@alexfauquette alexfauquette alexfauquette approved these changes

Assignees

@flaviendelangle flaviendelangle

Labels
component: pickers This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flaviendelangle @mui-bot @LukasTy @alexfauquette