Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Fix type definitions #596

Merged
merged 2 commits into from
Nov 16, 2020
Merged

Conversation

tooppaaa
Copy link
Contributor

@tooppaaa tooppaaa commented Nov 16, 2020

Closes #573

What I did:

  • Prevent *.test.* to go through types generation
  • Help createSelector to find its right typings

@tooppaaa tooppaaa marked this pull request as ready for review November 16, 2020 13:20
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! typescript labels Nov 16, 2020
@oliviertassinari oliviertassinari changed the title [core] Do not ship spec typings [DataGrid] Fix type definitions Nov 16, 2020
@oliviertassinari
Copy link
Member

In the future, we have two solutions:

  1. add a step in the CI to guarantee that the types are correct
  2. migrate to the main repository build approach, we never had this type of problem

I think that there is a high level of chance that we will be hit by this problem again in the future if we don't do any of 1. or 2. Time will tell

@oliviertassinari
Copy link
Member

@tooppaaa in case you need to use this patch now, you can use the version published to codesandbox ci.

@tooppaaa
Copy link
Contributor Author

@oliviertassinari oh thanks ! I didn't noticed that. Will do !

Happy to help on adding tests for the CI. I had some thoughts but no brillant idea here.

@oliviertassinari oliviertassinari merged commit e04d2f2 into mui:master Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataGrid] Build error: "Cannot find module '../../..'" and "Cannot find namespace 'Chai'"
2 participants