Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Include community package themeAugmentation in pro package types #5969

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Aug 31, 2022

Fixes #5965

In docs we mention that it's enough to import pro package types to include augmentation for all pickers, but that's not the case at the moment.

@LukasTy LukasTy added bug 🐛 Something doesn't work typescript component: pickers This is the name of the generic UI component, not the React module! labels Aug 31, 2022
@flaviendelangle flaviendelangle changed the title [pickers] Include base package themeAugmentation in pro package types [pickers] Include community package themeAugmentation in pro package types Aug 31, 2022
@mui-bot
Copy link

mui-bot commented Aug 31, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 336.5 703.4 639.7 554.62 143.336
Sort 100k rows ms 491.7 1,081.5 491.7 819.36 219.903
Select 100k rows ms 199.7 503.2 259.3 296.08 110.074
Deselect 100k rows ms 131.4 197.3 183.9 168.76 25.884

Generated by 🚫 dangerJS against a3da280

@LukasTy LukasTy merged commit 96c9887 into mui:master Aug 31, 2022
@LukasTy LukasTy deleted the fix-pro-theme-augmentation branch August 31, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pickers] @mui/x-date-pickers-pro themeAugmentation does not include @mui/x-date-pickers types
3 participants