[pickers] Do not hardcode date-fns elements in field components #5975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: pickers
|
These are the results for the performance tests:
|
LukasTy
reviewed
Aug 31, 2022
LukasTy
reviewed
Aug 31, 2022
flaviendelangle
commented
Sep 1, 2022
| ru: ruLocale, | ||
| ar: arSaLocale, | ||
| }; | ||
| const locales = ['en', 'fr', 'de', 'ru', 'ar-sa']; |
There was a problem hiding this comment.
I misused the localization api of dayjs
We are supposed to pass the locale string to the adapter, not the locale object
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
LukasTy
reviewed
Sep 1, 2022
packages/x-date-pickers/src/internals/hooks/useField/useField.utils.ts
Outdated
Show resolved
Hide resolved
LukasTy
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc preview
AdapterDateFnsandAdapterDayjswith field-related elements to avoid having to touch@date-ioduring the unstable phase of the fieldsdate-fnselements in the field codebasedayjs