Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Support getRowId in the replaceRows method #5988

Merged
merged 2 commits into from
Sep 1, 2022
Merged

[DataGrid] Support getRowId in the replaceRows method #5988

merged 2 commits into from
Sep 1, 2022

Conversation

flaviendelangle
Copy link
Member

No description provided.

@flaviendelangle flaviendelangle added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels Sep 1, 2022
@flaviendelangle flaviendelangle self-assigned this Sep 1, 2022
@mui-bot
Copy link

mui-bot commented Sep 1, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 354.3 722 496.5 530.36 147.283
Sort 100k rows ms 572.8 937.5 855.4 819.18 128.616
Select 100k rows ms 171.9 280.8 260 248.52 39.799
Deselect 100k rows ms 159.7 239 206.3 203.68 25.743

Generated by 🚫 dangerJS against 0612bca

@DanailH DanailH merged commit bf5fb2c into mui:master Sep 1, 2022
@flaviendelangle flaviendelangle deleted the getRowId-replaceRows branch September 1, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanailH DanailH Awaiting requested review from DanailH

Assignees

@flaviendelangle flaviendelangle

Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flaviendelangle @mui-bot @DanailH