Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix typo #5990

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Conversation

flaviendelangle
Copy link
Member

No description provided.

@flaviendelangle flaviendelangle self-assigned this Sep 1, 2022
@flaviendelangle flaviendelangle added the core Infrastructure work going on behind the scenes label Sep 1, 2022
@mui-bot
Copy link

mui-bot commented Sep 1, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 393 766.6 610.4 583.44 157.69
Sort 100k rows ms 645.6 1,173.6 775.5 893.62 179.131
Select 100k rows ms 197.8 365.2 293.2 296.54 61.419
Deselect 100k rows ms 160 288.2 216.4 227.92 44.438

Generated by 🚫 dangerJS against c5291f9

@DanailH
Copy link
Member

DanailH commented Sep 1, 2022

Thanks, @flaviendelangle. Can you also add this diff?

index 0b25a4195..8e35772cc 100644
--- a/docs/data/data-grid/row-updates/row-updates.md
+++ b/docs/data/data-grid/row-updates/row-updates.md
@@ -60,7 +60,7 @@ To enable lazy loading, there are a few steps you need to follow:
 First, set `rowsLoadingMode="server"`.
 Then, set `rowCount` to reflect the number of available rows on the server.
 Third, set a callback function on `onFetchRows` to load the data corresponding to the row indices passed within `GridFetchRowsParams`.
-Finally, replace the empty rows with the newly fetched ones using `apiRef.current.replaceRows()` like in the demo below.
+Finally, replace the empty rows with the newly fetched ones using `apiRef.current.unstable_replaceRows()` like in the demo below.

 {{"demo": "LazyLoadingGrid.js", "bg": "inline", "disableAd": true}}

@@ -68,6 +68,10 @@ Finally, replace the empty rows with the newly fetched ones using `apiRef.curren
 The `onFetchRows` callback is called every time a new row is in the viewport, so when you scroll, you can easily send multiple requests to your backend. We recommend developers limit those by implementing debouncing.
 :::

+:::warning
+For now, lazy loading rows does not work with row grouping or tree data.
+:::
+
 :::info
 In order for filtering and sorting to work you need to set their modes to `server`.
 You can find out more information about how to do that on the [server-side filter page](/x/react-data-grid/filtering/#server-side-filter) and on the [server-side sorting page](/x/react-data-grid/sorting/#server-side-sorting).

@flaviendelangle flaviendelangle merged commit ce2a76e into mui:master Sep 1, 2022
@flaviendelangle flaviendelangle deleted the lazy-loading-typo branch September 1, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants