[DataGrid] Server filters #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will open another PR for the rest
|
packages/grid/_modules_/grid/components/columnHeaders/ColumnHeaderFilterIcon.tsx
Outdated
Show resolved
Hide resolved
packages/grid/_modules_/grid/components/columnHeaders/ColumnHeaderFilterIcon.tsx
Outdated
Show resolved
Hide resolved
packages/grid/_modules_/grid/components/columnHeaders/ColumnHeaderItem.tsx
Outdated
Show resolved
Hide resolved
packages/grid/_modules_/grid/components/columnHeaders/ColumnHeaderItem.tsx
Outdated
Show resolved
Hide resolved
packages/grid/_modules_/grid/components/columnHeaders/ColumnHeaderMenuIcon.tsx
Outdated
Show resolved
Hide resolved
packages/grid/_modules_/grid/components/columnHeaders/ColumnHeadersItemCollection.tsx
Outdated
Show resolved
Hide resolved
packages/grid/_modules_/grid/components/columnHeaders/ColumnHeaderFilterIcon.tsx
Show resolved
Hide resolved
oliviertassinari
approved these changes
Dec 2, 2020
There was a problem hiding this comment.
I think that we will need to change the workflow, we keep bundling changes that could be done isolated (making quality reviews hard, I have only surfaced it), introducing new features without documentation (making it harder to design great APIs, and great documentation), fixing bugs without test cases (open the doors to regressions).
oliviertassinari
requested changes
Dec 2, 2020
packages/grid/_modules_/grid/components/columnHeaders/ColumnHeaderItem.tsx
Show resolved
Hide resolved
packages/grid/_modules_/grid/components/columnHeaders/ColumnHeaderItem.tsx
Show resolved
Hide resolved
packages/grid/_modules_/grid/components/columnHeaders/ColumnHeaderItem.tsx
Show resolved
Hide resolved
packages/grid/_modules_/grid/components/menu/columnMenu/ColumnsMenuItem.tsx
Show resolved
Hide resolved
packages/grid/_modules_/grid/components/columnHeaders/ColumnHeaderFilterIcon.tsx
Show resolved
Hide resolved
packages/grid/_modules_/grid/components/columnHeaders/ColumnHeaderFilterIcon.tsx
Show resolved
Hide resolved
|
Oops, I had some other suggestions in my draft |
I will integrate them in my next PR. |
oliviertassinari
added a commit
to oliviertassinari/mui-x
that referenced
this pull request
Dec 5, 2020
Review of mui#649
zannager
added
the
component: data grid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix most #633