[test] Allow running all the tests in strict mode #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtassone
reviewed
Dec 7, 2020
| ErrorBoundary, | ||
| // @ts-expect-error need to migrate helpers to TypeScript | ||
| createEvent, | ||
| } from 'test/utils'; |
There was a problem hiding this comment.
How long would it take to migrate them?
There was a problem hiding this comment.
I don't know, I have never looked at it. I think that we should ask ourselves if it's the best use of our time. So far, I think that the main value proposition of writing the tests in TypeScript is to increase the types coverage of the public API of the components. To make sure the types are solid.
|
Sorry for the delay @oliviertassinari . I tested it and it seems that with these changes I can remove the |
DanailH
approved these changes
Dec 8, 2020
oliviertassinari
force-pushed
the
strict-mode-tests
branch
from
c4c5ad6
to
ee6e9b1
Compare
|
Now that your PR is merged, I can rebase mine and remove the strict: false, done. If the CI is green, I think that we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DanailH Could you test that these changes allow removing the
strict: falsefrom the density pull request? We face the same issue when testing the filters and column selector feature.