[pickers] Do not loose the translations when using nested LocalizationProvider with each a localeText prop
#6895
+27
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
bug 🐛
7 tasks
flaviendelangle
changed the title
LocalizationProvider translations behaviors
flaviendelangle
commented
Nov 17, 2022
| @@ -56,10 +56,15 @@ export function LocalizationProvider<TDate>(inProps: LocalizationProviderProps<T | |||
| MuiPickersAdapterContext, | |||
| ) ?? { utils: undefined, localeText: undefined }; | |||
|
|
|||
| const tempLocaleText = React.useMemo( | |||
There was a problem hiding this comment.
Otherwise when inProps.localeText is not undefined, we loose the parent one.
These are the results for the performance tests:
|
flaviendelangle
changed the title
LocalizationProvider translations behaviorsLocalizationProvider with each a localeText prop
alexfauquette
approved these changes
Nov 17, 2022
Comment on lines
68
to
71
| const localeText = React.useMemo( | ||
| () => ({ ...props.localeText, ...parentLocaleText, ...inLocaleText }), | ||
| [props.localeText, parentLocaleText, inLocaleText], | ||
| ); |
There was a problem hiding this comment.
props.localeText is not obvious to get
What about moving this after props destructuring to be able to write
() => ({ ...defaultizedLocaleText, ...parentLocaleText, ...inLocaleText }),
There was a problem hiding this comment.
OK for me, I'll just rename defaultizedLocaleText into themeLocaleText to make clear that it can only contain the theme value and never the value from the inProps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.