Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Stop exporting root base state selectors #6912

Merged
merged 4 commits into from
Nov 23, 2022
Merged

[DataGrid] Stop exporting root base state selectors #6912

merged 4 commits into from
Nov 23, 2022

Conversation

DanailH
Copy link
Member

@DanailH DanailH commented Nov 18, 2022 •
edited

Fixes #5623
Fixes #5619
Fixes #5622
Fixes #5621

@DanailH DanailH added breaking change component: data grid This is the name of the generic UI component, not the React module! labels Nov 18, 2022
@DanailH DanailH self-assigned this Nov 18, 2022
@mui-bot
Copy link

mui-bot commented Nov 18, 2022 •
edited

Messages
📖 Netlify deploy preview: https://deploy-preview-6912--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 625 886.4 657.7 737.1 115.956
Sort 100k rows ms 575.9 1,048.3 857.9 873.76 162.037
Select 100k rows ms 255.5 284.4 274.5 270.9 11.877
Deselect 100k rows ms 141.2 213.6 169.8 173.68 28.922

Generated by 🚫 dangerJS against 5af31db

flaviendelangle
flaviendelangle reviewed Nov 18, 2022
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

If you could write the breaking changes for automatic import on the changelog it would be great

@DanailH DanailH merged commit 4f2e1ea into mui:next Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@cherniavskii cherniavskii cherniavskii approved these changes

@MBilalShafi MBilalShafi Awaiting requested review from MBilalShafi

@m4theushw m4theushw Awaiting requested review from m4theushw

Assignees

@DanailH DanailH

Labels
breaking change component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
4 participants
@DanailH @mui-bot @flaviendelangle @cherniavskii