[docs] Fix toggle button bug in demos in Custom Components page #6913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clicking on a toggle button twice makes the content disappear * This commit fixes that in two demos in the page * This commit makes sure to make relevant changes for both the .js and .tsx files
These are the results for the performance tests:
|
LukasTy
added
docs
flaviendelangle
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Thanks again for your contribution !
This PR makes sure to make relevant changes for both the .js and .tsx files
I don't know if you made the changes on the .js file by hand
But just in case, you can automatically generate it with yarn docs:typescript:formatted
|
@flaviendelangle I totally made all those changes manually 😁 Thanks for the tip ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #6896
.jsand.tsxfilesThe demos in question: https://next.mui.com/x/react-date-pickers/custom-components/#component-3