Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Fix focus management #6914

Merged
merged 8 commits into from
Nov 23, 2022
Merged

Conversation

alexfauquette
Copy link
Member

No description provided.

@alexfauquette alexfauquette added the component: pickers This is the name of the generic UI component, not the React module! label Nov 18, 2022
@@ -21,7 +21,6 @@ interface DateViewRendererProps<TDate>
export const renderDateView = <TDate extends unknown>(props: DateViewRendererProps<TDate>) => (
<DateCalendar
{...props}
autoFocus
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoFocus has no effect if focusedView is controlled

@mui-bot
Copy link

mui-bot commented Nov 18, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-6914--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 664 1,449.4 664 924.64 293.597
Sort 100k rows ms 848.2 1,332.1 848.2 1,016.64 171.906
Select 100k rows ms 218 391 296.8 301.36 67.408
Deselect 100k rows ms 148 390.5 288.2 274.98 77.646

Generated by 🚫 dangerJS against 22b6da1

Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior make sense
If you could add a test case for the fix it does, that would be great

@alexfauquette alexfauquette merged commit f035085 into mui:next Nov 23, 2022
@alexfauquette alexfauquette deleted the fix-focus branch November 23, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants