-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add new "Expired package version" error type #6937
Merged
oliviertassinari
merged 5 commits into
mui:next
from
oliviertassinari:polish-error-message
Nov 24, 2022
Merged
[docs] Add new "Expired package version" error type #6937
oliviertassinari
merged 5 commits into
mui:next
from
oliviertassinari:polish-error-message
Nov 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
Improvements or additions to the documentation
package: x-license
Specific to @mui/x-license.
labels
Nov 20, 2022
oliviertassinari
force-pushed
the
polish-error-message
branch
from
November 20, 2022 18:15
f7e156d
to
c06ae23
Compare
These are the results for the performance tests:
|
oliviertassinari
force-pushed
the
polish-error-message
branch
2 times, most recently
from
November 20, 2022 18:42
a0e1e1c
to
6ef8b92
Compare
oliviertassinari
force-pushed
the
polish-error-message
branch
4 times, most recently
from
November 20, 2022 19:04
142eed8
to
47c5d2f
Compare
oliviertassinari
force-pushed
the
polish-error-message
branch
from
November 20, 2022 19:38
47c5d2f
to
35ba4a3
Compare
joserodolfofreitas
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great with the normalized error messages 👌
oliviertassinari
changed the title
[docs] Add new "Unlicensed package version" error type
[docs] Add new "Expired package version" error type
Nov 23, 2022
Co-authored-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com> Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
oliviertassinari
added a commit
that referenced
this pull request
Nov 24, 2022
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com> Co-authored-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could still do a lot more to improve the DX but I didn't want to have more than 100 LOCs on a single PR and keep this a low time investment from my end. My assumption is that the DX correlates with the conversion rate to a higher plan.
https://deploy-preview-6937--material-ui-x.netlify.app/x/introduction/licensing/#validation-failures