Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add new "Expired package version" error type #6937

Merged
merged 5 commits into from
Nov 24, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 20, 2022

We could still do a lot more to improve the DX but I didn't want to have more than 100 LOCs on a single PR and keep this a low time investment from my end. My assumption is that the DX correlates with the conversion rate to a higher plan.

https://deploy-preview-6937--material-ui-x.netlify.app/x/introduction/licensing/#validation-failures

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation package: x-license Specific to @mui/x-license. labels Nov 20, 2022
@mui-bot
Copy link

mui-bot commented Nov 20, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-6937--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 862.6 1,305.3 1,305.3 1,088.5 160.118
Sort 100k rows ms 898.4 1,297.6 1,212.1 1,152.98 135.94
Select 100k rows ms 257.7 377.5 302.5 305.32 41.412
Deselect 100k rows ms 199.9 471 261 293.02 92.744

Generated by 🚫 dangerJS against 56574d5

@oliviertassinari oliviertassinari force-pushed the polish-error-message branch 2 times, most recently from a0e1e1c to 6ef8b92 Compare November 20, 2022 18:42
@oliviertassinari oliviertassinari marked this pull request as ready for review November 20, 2022 18:42
@oliviertassinari oliviertassinari force-pushed the polish-error-message branch 4 times, most recently from 142eed8 to 47c5d2f Compare November 20, 2022 19:04
Copy link
Member

@joserodolfofreitas joserodolfofreitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great with the normalized error messages 👌

docs/data/introduction/licensing/licensing.md Outdated Show resolved Hide resolved
docs/data/introduction/licensing/licensing.md Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari changed the title [docs] Add new "Unlicensed package version" error type [docs] Add new "Expired package version" error type Nov 23, 2022
oliviertassinari and others added 2 commits November 23, 2022 11:58
Co-authored-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com>
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@oliviertassinari oliviertassinari merged commit eb63ef7 into mui:next Nov 24, 2022
@oliviertassinari oliviertassinari deleted the polish-error-message branch November 24, 2022 10:56
oliviertassinari added a commit that referenced this pull request Nov 24, 2022
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: x-license Specific to @mui/x-license.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants