Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Cleanup describeValidation #6942

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Nov 21, 2022

  • Type the parameters of describeConformance
  • Move all getOptions outside of the it (we had some outside and some inside)
  • Remove the ignoredProps (was used on 2 components and it had no effect) => remove the propsToTest checks
  • Replace isLegacyPicker by componentFamily
  • Replace skip by checks inside the test suites based on componentFamily
  • Replace name by checks inside the test suites based on componentFamily

The main idea is two reduce the amount of ways to disable some tests and how to customize the default props.
We now have 2 properties:

  • views => describes which part of dates can be edited (through the UI view or the field)
  • componentFamily => describes the type of component being used (to set custom default props, or disable UI view tests on field for instance)

Plus isSingleInput on range validation which remains unchanged.

@flaviendelangle flaviendelangle self-assigned this Nov 21, 2022
@mui-bot
Copy link

mui-bot commented Nov 21, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-6942--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 625.3 1,700.2 655.4 904.86 404.604
Sort 100k rows ms 671.3 1,225.7 671.3 965.84 182.058
Select 100k rows ms 295.5 305.6 300.8 300.82 3.292
Deselect 100k rows ms 158.8 298.7 204.1 213.66 51.471

Generated by 🚫 dangerJS against 4ca3d15

@flaviendelangle flaviendelangle added test core Infrastructure work going on behind the scenes component: pickers This is the name of the generic UI component, not the React module! labels Nov 21, 2022
@flaviendelangle flaviendelangle marked this pull request as ready for review November 21, 2022 11:24
@flaviendelangle flaviendelangle merged commit 685282b into mui:next Nov 21, 2022
@flaviendelangle flaviendelangle deleted the validation-tests-refacto branch November 21, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants