Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Prevents master detail panel toggle with Ctrl+Enter #6945

Merged
merged 1 commit into from
Nov 23, 2022
Merged

[DataGrid] Prevents master detail panel toggle with Ctrl+Enter #6945

merged 1 commit into from
Nov 23, 2022

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Nov 21, 2022 •
edited

Closes #5613

Changelog

Breaking changes

  • Ctrl/Cmd + Enter will no longer toggle the master detail panel

@MBilalShafi MBilalShafi added breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x design: ux labels Nov 21, 2022
@MBilalShafi MBilalShafi self-assigned this Nov 21, 2022
@mui-bot
Copy link

mui-bot commented Nov 21, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-6945--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 665.7 915.6 723.2 780.72 98.667
Sort 100k rows ms 708.3 1,132.5 708.3 958.02 157.183
Select 100k rows ms 219.6 291.8 238 253.92 30.915
Deselect 100k rows ms 155.4 308.8 215.3 233.5 59.582

Generated by 🚫 dangerJS against 9ccf330

@MBilalShafi MBilalShafi merged commit cbdd8fb into mui:next Nov 23, 2022
@MBilalShafi MBilalShafi deleted the master-detail-space-only-toggle branch November 23, 2022 04:53
@oliviertassinari oliviertassinari added design This is about UI or UX design, please involve a designer and removed design: ux labels Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

@m4theushw m4theushw Awaiting requested review from m4theushw

@DanailH DanailH Awaiting requested review from DanailH

Assignees

@MBilalShafi MBilalShafi

Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer v6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Do not toggle the panel with Ctrl+Enter
4 participants
@MBilalShafi @mui-bot @cherniavskii @oliviertassinari