[pickers] Fix usage with Shadow DOM #6952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
force-pushed
the
shadow-dom-active-element
branch
from
7d2f8ed
to
14d05f7
Compare
flaviendelangle
added
bug 🐛
These are the results for the performance tests:
|
m4theushw
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
I think that if you want to add a test you can do by first creating a container, attaching a Shadow DOM to it, then pass its container.shadowRoot to the container option of RTL's render. You'll need to use custom queries because the default ones won't dive into the internals of the Shadow DOM. https://www.npmjs.com/package/shadow-dom-testing-library may help.
flaviendelangle
added a commit
to flaviendelangle/mui-x
that referenced
this pull request
Nov 23, 2022
flaviendelangle
added a commit
that referenced
this pull request
Nov 23, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6841
Reproduction case before
Reproduction case after
Not sure how to test that
@m4theushw I've also use your utility function for the other occurrence of
document.activeElement