Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix live edit #6975

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 23, 2022

Revert #6681. Same bug as in mui/material-ui#35118 (comment).

HEAD, broken: https://637e2b8be1aade00098a3987--material-ui-x.netlify.app/x/react-data-grid/#DataGridProDemo
PR, works: https://deploy-preview-6975--material-ui-x.netlify.app/x/react-data-grid/#DataGridProDemo

I have no idea what's wrong but it would be great to see if the problem is on our side or Next.js's side

Same bug on the master branch: https://mui.com/x/react-data-grid/.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work docs Improvements or additions to the documentation regression A bug, but worse labels Nov 23, 2022
@mui-bot
Copy link

mui-bot commented Nov 23, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-6975--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 679.9 1,187.8 683 867.24 191.746
Sort 100k rows ms 640.3 1,238.5 1,238.5 982.42 201.635
Select 100k rows ms 171.5 395.3 284.4 281.62 72.978
Deselect 100k rows ms 162.4 299.8 200.1 208.48 50.244

Generated by 🚫 dangerJS against 1ab2507

@oliviertassinari oliviertassinari marked this pull request as ready for review November 23, 2022 11:47
@oliviertassinari oliviertassinari merged commit 4891eaf into mui:next Nov 23, 2022
@oliviertassinari oliviertassinari deleted the fix-live-edit branch November 23, 2022 14:24
oliviertassinari added a commit that referenced this pull request Nov 23, 2022
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Nov 23, 2022

We will need to figure out what's wrong. This fix is only on the surface, I won't have the time to dive deeper. I have applied the same fix to master.

cc @flaviendelangle in case you are on dependencies update duty later on, Next.js is breaking it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants