Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPro] Fix lazy-loaded rows not working with updateRows API method #6976

Merged
merged 1 commit into from
Nov 23, 2022
Merged

[DataGridPro] Fix lazy-loaded rows not working with updateRows API method #6976

merged 1 commit into from
Nov 23, 2022

Conversation

cherniavskii
Copy link
Member

Port of #6875 to the next branch

@cherniavskii cherniavskii added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user feature: Row loading Related to the data grid Row loading features feature: State management Related to the data grid State management feature labels Nov 23, 2022
@cherniavskii cherniavskii mentioned this pull request Nov 23, 2022
Merged
1 task
@mui-bot
Copy link

mui-bot commented Nov 23, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-6976--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 964.1 1,495.7 1,213.4 1,137.4 199.124
Sort 100k rows ms 904 1,566.7 1,436.6 1,227.7 248.661
Select 100k rows ms 316.8 514.9 355.9 376.94 72.949
Deselect 100k rows ms 224 367.6 272.4 277.36 52.028

Generated by 🚫 dangerJS against 91470ff

@cherniavskii cherniavskii merged commit 0a1d8a6 into mui:next Nov 23, 2022
@cherniavskii cherniavskii deleted the lazy-loading-updateRows-next branch November 23, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanailH DanailH DanailH approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Row loading Related to the data grid Row loading features feature: State management Related to the data grid State management feature plan: Pro Impact at least one Pro user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cherniavskii @mui-bot @DanailH