[docs] Add support for API pages of unstable components #6981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
docs
flaviendelangle
commented
Nov 24, 2022
| const projectsWithThisComponent = allProjectsName.filter((projectName) => { | ||
| const currenetProject = projects.get(projectName) as Project; | ||
| const symbol = currenetProject.exports[reactApi.name]; | ||
| reactApi.packages = Array.from(projects.keys()) |
There was a problem hiding this comment.
This modification allow to have the correct import with Unstable_ on the api page
There was a problem hiding this comment.
You probably meant this modification? 🤔
There was a problem hiding this comment.
The whole block
We need to get the symbol (otherwise we have no import at all on the api page) and we need to pass the name of the export (otherwise the import would not have the Unstable_ prefix)
| @@ -4,27 +4,91 @@ | |||
|
|
|||
| ## Components | |||
|
|
|||
| - [DateCalendar](/x/api/date-pickers/date-calendar/) | |||
| ### Pickers | |||
There was a problem hiding this comment.
I added the unstable components and ordered everything because it was becoming impossible to read
flaviendelangle
commented
Nov 24, 2022
These are the results for the performance tests:
|
LukasTy
approved these changes
Nov 24, 2022
| const projectsWithThisComponent = allProjectsName.filter((projectName) => { | ||
| const currenetProject = projects.get(projectName) as Project; | ||
| const symbol = currenetProject.exports[reactApi.name]; | ||
| reactApi.packages = Array.from(projects.keys()) |
There was a problem hiding this comment.
You probably meant this modification? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6695