[DataGrid] Rename hideToolbar prop to showToolbar #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested changes
Dec 8, 2020
There was a problem hiding this comment.
For the documentation, I think that we could document displaying the de density toolbar before the density prop. How about this structure?
Density selector
How do enable the toolbar,
Demo
Have a note about how to hide the selector when the toolbar is visible, no demo for it
Density prop
Demo
docs/src/pages/components/data-grid/getting-started/getting-started.md
Outdated
Show resolved
Hide resolved
oliviertassinari
approved these changes
Dec 8, 2020
dtassone
approved these changes
Dec 8, 2020
|
@mbrookes can I merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up to the Density selector PR #606 I'm renaming the
hideToolbarprop toshowToolbarto make the toolbar opt-in.This decision was based on both discussions that happened on the #606 PR and in Slack.