[DataGrid] Add 'nonce' prop to allow inline style if user has CSP #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
oliviertassinari
added
the
component: data grid
oliviertassinari
approved these changes
Dec 12, 2020
dtassone
reviewed
Dec 15, 2020
| @@ -123,7 +123,7 @@ export const GridComponent = React.forwardRef<HTMLDivElement, GridComponentProps | |||
| } | |||
|
|
|||
| return ( | |||
| <AutoSizer onResize={onResize}> | |||
| <AutoSizer onResize={onResize} nonce={props.nonce}> | |||
There was a problem hiding this comment.
Should it be on on the AutoSizer or GridRoot 🤔
There was a problem hiding this comment.
What do you mean? nonce is not an HTML attribute in case the confusion come from there.
|
@ZeeshanTamboli Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #541
Introduce
nonceprop for DataGrid and XGrid. Updated docs API as well. Let me know if I missed anything or any change.My first PR for the Material-UI organization. You guys do excellent work! Looking forward to contribute more!
Thanks!