Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Upgrade monorepo #7307

Merged
merged 4 commits into from
Dec 27, 2022
Merged

[core] Upgrade monorepo #7307

merged 4 commits into from
Dec 27, 2022

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Dec 23, 2022 •
edited

@LukasTy LukasTy added docs Improvements or additions to the documentation core Infrastructure work going on behind the scenes labels Dec 23, 2022
LukasTy
LukasTy commented Dec 23, 2022
View reviewed changes
docs/src/modules/constants.js
@@ -1 +0,0 @@
module.exports = require('../../../node_modules/@mui/monorepo/docs/src/modules/constants');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No exports from the updated constants file is used anywhere, so I removed it.

@mui-bot
Copy link

mui-bot commented Dec 23, 2022 •
edited

Messages
📖 Netlify deploy preview: https://deploy-preview-7307--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 655.1 967.3 756.5 791.86 120.829
Sort 100k rows ms 641.3 1,005.9 871.2 864.18 121.028
Select 100k rows ms 200.3 237.8 225.6 223.72 12.633
Deselect 100k rows ms 197.3 314.5 206.9 237.68 46.953

Generated by 🚫 dangerJS against 7a2f3b3

@LukasTy LukasTy merged commit 196bedc into mui:next Dec 27, 2022
@LukasTy LukasTy deleted the upgrade-monorepo branch December 27, 2022 08:09
@cherniavskii cherniavskii mentioned this pull request Dec 29, 2022
Merged
@oliviertassinari oliviertassinari mentioned this pull request Feb 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

@flaviendelangle flaviendelangle Awaiting requested review from flaviendelangle

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LukasTy @mui-bot @alexfauquette