[core] Handle selection edge case #7350
Conversation
oliviertassinari
added
core
These are the results for the performance tests:
|
|
I think that it has barely any impact, so most people wouldn't care. |
oliviertassinari
changed the title
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
| @@ -26,15 +26,15 @@ function writeToClipboardPolyfill(data: string) { | |||
| } | |||
|
|
|||
| function hasNativeSelection(element: HTMLInputElement) { | |||
| if (window.getSelection()?.toString() !== '') { | |||
There was a problem hiding this comment.
@cherniavskii I think that this wasn't exactly correct. Per https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining
If the object accessed or function called is undefined or null, it returns undefined instead of throwing an error.
So when the selection returns null, the chaining returns undefined which we then compare to ''. it's different, so hasNativeSelection say there is a selection. But there is no selection in this case, in theory, per https://developer.mozilla.org/en-US/docs/Web/API/Window/getSelection.
When called on an <iframe> that is not displayed (e.g., where display: none is set) Firefox will return null
Per https://github.com/mui/material-ui/pull/35670/files#r1059417694, this might be better