Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[DataGrid] Store the outlined cell in the state (#7111)" #7481

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Revert "[DataGrid] Store the outlined cell in the state (#7111)" #7481

merged 1 commit into from
Jan 12, 2023

Conversation

m4theushw
Copy link
Member

This reverts commit 0203346.

I realized #7111 is not necessary for #6567 (comment) so I'm reverting before releasing a breaking change.

@m4theushw m4theushw added the component: data grid This is the name of the generic UI component, not the React module! label Jan 11, 2023
@mui-bot
Copy link

mui-bot commented Jan 11, 2023

Messages
📖 Netlify deploy preview: https://deploy-preview-7481--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 651.2 1,190.9 651.2 877.56 247.894
Sort 100k rows ms 596.9 1,322.8 596.9 1,011.66 270.14
Select 100k rows ms 215.7 339.5 281.5 276.32 42.075
Deselect 100k rows ms 153.1 275.7 225.1 217.8 43.692

Generated by 🚫 dangerJS against 96225fd

@m4theushw m4theushw merged commit fbf8102 into mui:next Jan 12, 2023
@m4theushw m4theushw deleted the revert-outline-state branch January 12, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m4theushw @mui-bot