[DataGrid] Fix column width calculation after data changes #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanailH
added
bug 🐛
|
|
||
| render(<Test />); | ||
|
|
||
| await sleep(100); |
There was a problem hiding this comment.
Could you try to replace this sleep with a setProps? Sleep make tests flaky and slow, exactly what we hate the most about tests.
There was a problem hiding this comment.
In the current setup, 500 tests would run in about 40s (by extrapolation). If all the tests add 100ms, we would x2 the duration. It's not negligeable.
dtassone
reviewed
Dec 18, 2020
packages/grid/_modules_/grid/hooks/features/columns/useColumns.ts
Outdated
Show resolved
Hide resolved
oliviertassinari
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #708
Fixes #716
Also added a test to cover the case.