Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Allow to customize label and value for singleSelect #7684

Merged
merged 10 commits into from
Feb 16, 2023
Merged

[DataGrid] Allow to customize label and value for singleSelect #7684

merged 10 commits into from
Feb 16, 2023

Conversation

m4theushw
Copy link
Member

@m4theushw m4theushw commented Jan 24, 2023 •
edited
Loading

@m4theushw m4theushw added the component: data grid This is the name of the generic UI component, not the React module! label Jan 24, 2023
@mui-bot
Copy link

mui-bot commented Jan 24, 2023 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-7684--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 660.3 1,242.2 691.3 903.08 212.479
Sort 100k rows ms 861.4 1,160.1 861.4 990.38 106.401
Select 100k rows ms 222.7 313.8 252.5 264.9 37.887
Deselect 100k rows ms 186.3 305.6 202.4 232.72 48.504

Generated by 🚫 dangerJS against 97dfb27

@m4theushw m4theushw force-pushed the single-select-customize-label-and-value branch from cf46cda to 5887a3b Compare January 24, 2023 01:06
@m4theushw m4theushw mentioned this pull request Jan 24, 2023
Merged
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 10, 2023
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 13, 2023
@m4theushw m4theushw marked this pull request as ready for review February 14, 2023 12:32
@m4theushw m4theushw merged commit c72cf1a into mui:next Feb 16, 2023
@m4theushw m4theushw deleted the single-select-customize-label-and-value branch February 16, 2023 18:02
@cherniavskii cherniavskii mentioned this pull request May 17, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

@DanailH DanailH Awaiting requested review from DanailH

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Add a default valueParser and valueFormatter to singleSelect columns
3 participants
@m4theushw @mui-bot @cherniavskii