Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Fix an error when deleting pinned row using actions column button #7767

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Jan 30, 2023

@cherniavskii cherniavskii added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! v5.x feature: Row pinning Related to the data grid Row pinning feature labels Jan 30, 2023
@mui-bot
Copy link

mui-bot commented Jan 30, 2023

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 577.9 1,010.5 600.8 808.84 187.287
Sort 100k rows ms 729.6 1,161 729.6 960.5 169.554
Select 100k rows ms 169 395.8 237.4 268.94 77.091
Deselect 100k rows ms 153.4 309.3 205.3 232.3 57.943

Generated by 🚫 dangerJS against e7444b9

@cherniavskii cherniavskii marked this pull request as ready for review January 31, 2023 10:39
@cherniavskii cherniavskii added the plan: Pro Impact at least one Pro user label Feb 1, 2023
@cherniavskii cherniavskii merged commit 0583d5e into mui:master Feb 1, 2023
@cherniavskii cherniavskii deleted the fix-updating-pinned-rows branch February 1, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Row pinning Related to the data grid Row pinning feature plan: Pro Impact at least one Pro user v5.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants