-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Use unformatted number and boolean values for CSV serialization #7809
Conversation
These are the results for the performance tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% with this change. I asked two banks in Brazil to export to CSV my account statement and both exported monetary values as "9.999,99", which is what I see in the web page. The same happened for dates, it was exported according to my locale, so "dd/mm/yyyy". Did you explore adding a valueSetter
to these columns? Its purpose was exactly to convert the value entered by the user to machine format.
I think that would work. I actually thought about adding functions that would allow transforming cell values for both import and export. I'm not sure Maybe add new functions to the column definition for import/export specifically? |
They will have to override in certain occasions. For instance, I don't know if we can provide a single default
We can do that too. AG Grid has |
@cherniavskii Since we are now in stable and it's a breaking change PR, should it be closed? |
Extracted from #7389, necessary for #199.
Otherwise it won't be possible to properly parse these values when pasting from clipboard.
Changelog
Breaking changes
CSV export:
number
andboolean
columns will export raw unformatted values instead of formatted values: