Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Upgrade monorepo #7849

Merged
merged 12 commits into from
Feb 9, 2023
Merged

Conversation

cherniavskii
Copy link
Member

To include banner from mui/material-ui#36074

@cherniavskii cherniavskii added the core Infrastructure work going on behind the scenes label Feb 7, 2023
@mui-bot
Copy link

mui-bot commented Feb 7, 2023

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 533.9 823.7 806.2 714.38 127.273
Sort 100k rows ms 558.2 1,074.5 807.9 850.2 169.764
Select 100k rows ms 239 288.8 245.2 257.98 20.618
Deselect 100k rows ms 161.9 284.2 202.3 222.32 49.979

Generated by 🚫 dangerJS against 4b776e7

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉
Maybe Netlify step just a fluke and you only need to re-run the pipeline? 🤔 🙈

@cherniavskii cherniavskii marked this pull request as ready for review February 8, 2023 20:00
version "5.10.16"
resolved "https://github.com/mui/material-ui.git#2abad795e4890829deb0fb40204a100b547a3873"
version "5.11.8"
resolved "https://github.com/mui/material-ui.git#c0c3d556a4d039f615188ecc5be6123f6de9156b"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's odd, I still see the v6-alpha in the deployment preview even though the resolved monorepo version points straight to the merge commit with this change: mui/material-ui@c0c3d55
Screenshot 2023-02-08 at 21 03 46

cc @LukasTy

Copy link
Member

@LukasTy LukasTy Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm... Interesting issue.
I've experienced the same locally, until I've deleted .next folder and restarted the dev server. 🤔
Maybe it's the same in Netlify? It might cache the built resources somewhere until you forcefully remove them. 🙈
TL.DR.: I think it should be fine when new docs are deployed. 🙈

EDIT: It could possibly be asserted by (re)creating a PR from this branch to trigger a deployment on a different "domain"/path.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've experienced the same locally, until I've deleted .next folder and restarted the dev server. 🤔

That is what I did locally too, but I didn't expect to see this problem in a preview deployment.

@cherniavskii cherniavskii merged commit fafef05 into mui:master Feb 9, 2023
@cherniavskii cherniavskii deleted the upgrade-monorepo-master branch February 9, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes v5.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants