New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Wrap column menu button with a tooltip #7890
[DataGrid] Wrap column menu button with a tooltip #7890
Conversation
Netlify deploy previewNetlify deploy preview: https://deploy-preview-7890--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
aria-controls={columnMenuId} | ||
id={columnMenuButtonId} | ||
{...rootProps.componentsProps?.baseIconButton} | ||
enterDelay={1000} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this delay a little bit above the user's expectation? As it's supposed to work in place of the default HTML tooltip which I guess is 0.3-0.5 seconds, do you think the delay should be set to a smaller number?
The MUI Tooltip also has a default delay of 0.1s and material design shows a minor delay in the image.
The same (1s) is the case for the filter button tooltip though (maybe there was a reason behind that which I am not aware of 🤔 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I used the same delay that was being used for the filter button tooltip.
I'm not sure why this exact value was used, maybe to simulate the behavior of aria-label
that is not shown immediately, but after a delay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably somewhere around the default delay for HTML title
attribute (0.3-0.5 seconds) would be closer to a normal user's expectation.
Not a big deal though. Being consistent with the filter button tooltip also seems fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably somewhere around the default delay for HTML title attribute (0.3-0.5 seconds) would be closer to a normal user's expectation.
Maybe it depends on the browser, but in Chromium, it seems to be more than 0.5s:
Screen.Recording.2023-04-05.at.19.06.43.mov
This comment was marked as outdated.
This comment was marked as outdated.
896f4ed
to
81ffbb9
Compare
Closes #7877