Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XGrid] Fix support for custom class name generators #793

Merged
merged 1 commit into from
Dec 29, 2020
Merged

[XGrid] Fix support for custom class name generators #793

merged 1 commit into from
Dec 29, 2020

Conversation

DanailH
Copy link
Member

@DanailH DanailH commented Dec 29, 2020

Fixes #790

@DanailH DanailH added bug 🐛 Something doesn't work components: XGrid labels Dec 29, 2020
@DanailH DanailH self-assigned this Dec 29, 2020
@oliviertassinari oliviertassinari changed the title [DataGrid] Change MuiXGrid-root to MuiDataGrid-root in XGrid component [XGrid] Fix support for custom class name generatros Dec 29, 2020
@oliviertassinari oliviertassinari changed the title [XGrid] Fix support for custom class name generatros [XGrid] Fix support for custom class name generators Dec 29, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 29, 2020 •
edited

  • I have renamed the label from DataGrid to XGrid so the changelog better differentiates what's coming in the MIT and Commercial versions.
  • I have changed the description so developers that read the changelog know if they should care or not about the change. In theory, nobody is using the .MuiXGrid-root class name to make customizations (I hope), otherwise, we would need to list this change as a breaking change.

@DanailH DanailH merged commit 382ae31 into mui:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees

@DanailH DanailH

Labels
bug 🐛 Something doesn't work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DanailH @oliviertassinari