Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add docs for data grid column selector #837

Merged

Conversation

DanailH
Copy link
Member

@DanailH DanailH commented Jan 11, 2021

Part 1 (docs) of 2 that is needed to wrap up #345

@DanailH DanailH added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! labels Jan 11, 2021
@DanailH DanailH self-assigned this Jan 11, 2021
@DanailH DanailH changed the title Add docs for Column Selector [DataGrid] Add docs for Column Selector Jan 11, 2021
@oliviertassinari oliviertassinari changed the title [DataGrid] Add docs for Column Selector [DataGrid] Add docs for Column selector Jan 11, 2021
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it's a bit weird that we display all the items in the toolbar, but I guess #726 will allow solving this.

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@DanailH
Copy link
Member Author

DanailH commented Jan 12, 2021

Looks good, it's a bit weird that we display all the items in the toolbar, but I guess #726 will allow solving this.

Yes I also didn't like it much but after the composable toolbar is done we can make the demo more purposeful.

@DanailH DanailH merged commit 3cb2d1d into mui:master Jan 12, 2021
@oliviertassinari oliviertassinari changed the title [DataGrid] Add docs for Column selector [docs] Add docs for data grid column selector Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants