Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Help contributors for l10n PRs #8503

Merged
merged 8 commits into from Apr 5, 2023
Merged

Conversation

alexfauquette
Copy link
Member

The idea is to automate a bit the l10n PR management. When a PR is opened and modifies the locales/ folder it:

  • Add l10n label (simplify finding l10n PRs in the list of PRs)
  • Add a comment with scripts to run to get the PR pass

Example of a PR in my fork: alexfauquette#9

@alexfauquette alexfauquette added the core Infrastructure work going on behind the scenes label Apr 4, 2023
@mui-bot
Copy link

mui-bot commented Apr 4, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-8503--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 679.3 1,136.1 713.4 861.76 172.892
Sort 100k rows ms 678.1 1,367.7 1,367.7 1,061.84 244.382
Select 100k rows ms 277.6 367.3 312 313.84 30.583
Deselect 100k rows ms 170.5 362.6 223.4 249.7 68.438

Generated by 🚫 dangerJS against ec374f7

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb improvement! ❤️ 💯 🚀

.github/workflows/help-l10n-contributors.yml Outdated Show resolved Hide resolved
.github/workflows/help-l10n-contributors.yml Outdated Show resolved Hide resolved
.github/workflows/help-l10n-contributors.yml Outdated Show resolved Hide resolved
.github/workflows/help-l10n-contributors.yml Outdated Show resolved Hide resolved
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
@alexfauquette alexfauquette merged commit 639f2bb into mui:master Apr 5, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants