[core] Fix the l10n helper by using danger instead of actions #8512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
commented
Apr 5, 2023
Netlify deploy previewNetlify deploy preview: https://deploy-preview-8512--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
|
The mui-bots always keep the message up to date, so I can not at the same time show it's working and have the PR ready for review |
LukasTy
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: We are getting usually 2 or 3 l10n PR per week. Contributors can not guess magically how to write a PR that passes the CI on the first try.
To save some maintainer time, and provide quick feedback to contributors, we can send a message listing all the steps to follow to get the CI green.
This has been tested as a github action, but it's for now impossible to display message on PR if they come from forked repositories. So this PR moves to the current danger.js file