Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Update peer dependency versions #8531

Merged
merged 1 commit into from Apr 7, 2023
Merged

[pickers] Update peer dependency versions #8531

merged 1 commit into from Apr 7, 2023

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Apr 6, 2023 •
edited

Fix #8530
Also tested and updated the minimum viable @mui/system version.

5.8.6 is the minimum version exposing useSlotProps.

@LukasTy LukasTy added bug 🐛 Something doesn't work core Infrastructure work going on behind the scenes component: pickers This is the name of the generic UI component, not the React module! labels Apr 6, 2023
@LukasTy LukasTy self-assigned this Apr 6, 2023
@mui-bot
Copy link

mui-bot commented Apr 6, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-8531--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 770.3 1,557.6 1,557.6 1,061.2 288.906
Sort 100k rows ms 828.3 1,494.6 1,216.9 1,172.94 212.237
Select 100k rows ms 290.4 390.5 305.2 331.9 41.96
Deselect 100k rows ms 173.9 292.9 243 245.38 40.537

Generated by 🚫 dangerJS against 3074140

@LukasTy LukasTy mentioned this pull request Apr 6, 2023
Merged
alexfauquette
alexfauquette approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effectively 5.8.6 is required for useSlotProps 👀

@LukasTy LukasTy merged commit 8380e58 into mui:master Apr 7, 2023
19 checks passed
@LukasTy LukasTy deleted the fix-outdated-peer-deps branch April 7, 2023 06:10
@oliviertassinari oliviertassinari mentioned this pull request May 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

@flaviendelangle flaviendelangle Awaiting requested review from flaviendelangle

Assignees

@LukasTy LukasTy

Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pickers] package is incompatible with @mui/material for versions equal to or lower than 5.8.x
3 participants
@LukasTy @mui-bot @alexfauquette