Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Allow to render the months before currentMonth instead of the one after #8592

Merged
merged 11 commits into from May 15, 2023

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Apr 12, 2023

Closes #4562
Doc preview

I'd be interested to discuss the DX here
There are probably a lot of other ways of allowing people to achieve the same result, I went for a very high level one.

  • Add doc
  • Add test

@flaviendelangle flaviendelangle added the component: pickers This is the name of the generic UI component, not the React module! label Apr 12, 2023
@flaviendelangle flaviendelangle self-assigned this Apr 12, 2023
@mui-bot
Copy link

mui-bot commented Apr 12, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-8592--material-ui-x.netlify.app/

Updated pages

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 676.7 1,203.3 676.7 910.98 210.192
Sort 100k rows ms 633.8 1,216.9 1,095.6 1,001.66 196.598
Select 100k rows ms 226.6 374.7 311.9 301.66 54.056
Deselect 100k rows ms 162.4 296.2 229.3 229.56 43.398

Generated by 🚫 dangerJS against fad8301

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way better solution IMHO! 🚀 💯

@flaviendelangle flaviendelangle merged commit 04e1ba2 into mui:master May 15, 2023
14 of 15 checks passed
@flaviendelangle flaviendelangle deleted the calendar-direction branch May 15, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DateRangePicker] Allow to control which month to display first
4 participants