New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Allow to render the months before currentMonth
instead of the one after
#8592
Merged
flaviendelangle
merged 11 commits into
mui:master
from
flaviendelangle:calendar-direction
May 15, 2023
Merged
[pickers] Allow to render the months before currentMonth
instead of the one after
#8592
flaviendelangle
merged 11 commits into
mui:master
from
flaviendelangle:calendar-direction
May 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: pickers
This is the name of the generic UI component, not the React module!
label
Apr 12, 2023
flaviendelangle
force-pushed
the
calendar-direction
branch
from
April 12, 2023 09:13
06145ab
to
80bbaa1
Compare
Netlify deploy previewNetlify deploy preview: https://deploy-preview-8592--material-ui-x.netlify.app/ Updated pagesThese are the results for the performance tests:
|
flaviendelangle
force-pushed
the
calendar-direction
branch
from
April 12, 2023 09:20
80bbaa1
to
a4d06dd
Compare
LukasTy
reviewed
Apr 24, 2023
packages/x-date-pickers-pro/src/DateRangeCalendar/DateRangeCalendar.tsx
Outdated
Show resolved
Hide resolved
flaviendelangle
force-pushed
the
calendar-direction
branch
from
May 9, 2023 08:18
a134d08
to
9e5c679
Compare
LukasTy
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Way better solution IMHO! 🚀 💯
docs/data/date-pickers/date-range-calendar/date-range-calendar.md
Outdated
Show resolved
Hide resolved
packages/x-date-pickers-pro/src/DateRangeCalendar/DateRangeCalendar.types.ts
Outdated
Show resolved
Hide resolved
alexfauquette
approved these changes
May 9, 2023
docs/data/date-pickers/date-range-calendar/date-range-calendar.md
Outdated
Show resolved
Hide resolved
packages/x-date-pickers-pro/src/DateRangeCalendar/DateRangeCalendar.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4562
Doc preview
I'd be interested to discuss the DX here
There are probably a lot of other ways of allowing people to achieve the same result, I went for a very high level one.