Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add no-op service worker to fix stale cache issue #8598

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

cherniavskii
Copy link
Member

This should solve mui/material-ui#36808, but only for MUI X.
I can apply this to MUI Core docs after it's solved in MUI X.
I followed this guide: https://developer.chrome.com/docs/workbox/remove-buggy-service-workers/

@cherniavskii cherniavskii added the docs Improvements or additions to the documentation label Apr 12, 2023
@mui-bot
Copy link

mui-bot commented Apr 12, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-8598--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 709.6 937.7 900.3 838.92 97.099
Sort 100k rows ms 670.1 1,391.6 1,391.6 1,070.1 242.169
Select 100k rows ms 291 408.6 327.3 337.66 40.376
Deselect 100k rows ms 183.3 314.3 233.2 244.3 51.998

Generated by 🚫 dangerJS against 86b6fef

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The plan would be to keep this "reset" SW for some time and only after some time (when hopefully most users have already got back to our docs) deploy a fixed caching SW? 🤔

@cherniavskii
Copy link
Member Author

The plan would be to keep this "reset" SW for some time and only after some time (when hopefully most users have already got back to our docs) deploy a fixed caching SW? 🤔

We should be fine without a caching SW (most of the resources are cached by the browser anyway) unless there's a strong reason to add one - like for offline support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants