Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Do not apply filters on
rowExpansionChange
#8671[DataGrid] Do not apply filters on
rowExpansionChange
#8671Changes from 8 commits
0cee1cd
0c9f390
b34e757
8e9ced1
1e1e912
952c8a4
db01474
b9cbd3d
d055c1d
0b1f969
7422d23
c58488b
baab0df
5b5cd60
daa6bd8
1aca18c
a10b77e
6bd5c21
9e99470
f0629a3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MBilalShafi
That's a very good point, I'm sure we can optimize aggregation (especially when there's a lot of aggregated columns) 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any opinions on this comment? Are footers sometimes hidden?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you can have aggregation footer for each row group - see https://mui.com/x/react-data-grid/aggregation/#AggregationGetAggregationPosition.tsx
When the group is filtered out, the aggregation footer should be hidden as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, the visibility of the group is always equal to the visibility of the footer, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not exactly, you can have a visible row group, but if it's not expanded - the footer row shouldn't be visible:
mui-x/packages/grid/x-data-grid-pro/src/utils/tree/utils.ts
Lines 268 to 269 in 9aa0d40
row-group-footer.mov