[DataGrid] Fix grid size calculation when .MuiDataGrid-main has border
#8882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherniavskii
added
component: data grid
Netlify deploy previewNetlify deploy preview: https://deploy-preview-8882--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
MBilalShafi
approved these changes
May 18, 2023
| // It should not have a horizontal scrollbar | ||
| expect(virtualScroller.scrollWidth - virtualScroller.clientWidth).to.equal(0); | ||
|
|
||
| await sleep(200); |
There was a problem hiding this comment.
Just curious if clock.tick could be used here alternatively too 🤔
There was a problem hiding this comment.
I guess that's an option too, but we'll need to use a fake clock for this.
If this test turns out to be flaky, I'll give it a try! 👍
romgrk
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8737
Scenario 1:
Before: https://codesandbox.io/s/data-grid-community-forked-3ctumy
After: https://codesandbox.io/s/data-grid-community-forked-4glro7
Scenario 2:
Before: https://codesandbox.io/s/sparkling-waterfall-3sdhkk?file=/demo.tsx
After: https://codesandbox.io/s/vigilant-curran-xgf9pt