Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Add customisation on panels #890

Merged
merged 18 commits into from
Jan 26, 2021
Merged

Conversation

dtassone
Copy link
Member

@dtassone dtassone commented Jan 21, 2021

Add customisation on 3 components

  • Filter panel
  • Columns panel
  • Panel

Fixes #895

@dtassone dtassone requested review from oliviertassinari and DanailH and removed request for oliviertassinari January 21, 2021 16:58
@oliviertassinari oliviertassinari changed the title [DataGrid] add customisation on panels [DataGrid] Add customisation on panels Jan 21, 2021
@oliviertassinari oliviertassinari added component: data grid This is the name of the generic UI component, not the React module! new feature New feature or request labels Jan 22, 2021
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend the following:

  1. We close this pull request, it's too ambitious to start with the customization of the panel when there are many unaddressed issues with the previous iteration. Instead, I propose we break it down into a bunch of small pull requests. Each will bring value to the product. This PR was great for exploration purposes.
  2. We fix the CSS injection order with the diff shared (reorder of the imports), if we want to anticipate emotion/sc, we can also remove the box-sizing wildcard inheritance.
  3. We fix the scroll regression [DataGrid] Scroll is broken when opening Column selector #895, useEnhancedEffect could be the solution.
  4. We add the componentsProps prop, add the missing API documentation at the same time.
  5. We fix the rerender regression, by replacing the wrapWithProps pattern with componentsProps.
  6. We fix the null-isf behavior of the components.
  7. We break down the style of the panel into smaller components.
  8. Finally, we add the customization of the panel 🎉.

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please break it down, it mixes too many unrelated changes that can deliver value on their own.

docs/pages/api-docs/data-grid.md Outdated Show resolved Hide resolved
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 25, 2021

Please break it down, it mixes too many unrelated changes that can deliver value on their own.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 25, 2021

Oops, I was on my phone, I didn't meant to close it, I have pressed the wrong button. I was hoping you would. The last commit looks good, I had something similar in mind for fixing it 👍

@dtassone dtassone reopened this Jan 25, 2021
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are close :)

docs/pages/api-docs/data-grid.md Outdated Show resolved Hide resolved
packages/grid/_modules_/grid/components/panel/Panel.tsx Outdated Show resolved Hide resolved
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to solve the last regressions we had on HEAD. I can make a release once it's merged.

@dtassone dtassone merged commit 6ce6ec1 into mui:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataGrid] Scroll is broken when opening Column selector
3 participants