-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Add customisation on panels #890
Conversation
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend the following:
- We close this pull request, it's too ambitious to start with the customization of the panel when there are many unaddressed issues with the previous iteration. Instead, I propose we break it down into a bunch of small pull requests. Each will bring value to the product. This PR was great for exploration purposes.
- We fix the CSS injection order with the diff shared (reorder of the imports), if we want to anticipate emotion/sc, we can also remove the box-sizing wildcard inheritance.
- We fix the scroll regression [DataGrid] Scroll is broken when opening Column selector #895,
useEnhancedEffect
could be the solution. - We add the
componentsProps
prop, add the missing API documentation at the same time. - We fix the rerender regression, by replacing the
wrapWithProps
pattern withcomponentsProps
. - We fix the null-isf behavior of the
components
. - We break down the style of the panel into smaller components.
- Finally, we add the customization of the panel 🎉.
packages/grid/_modules_/grid/components/containers/GridRootStyles.ts
Outdated
Show resolved
Hide resolved
packages/grid/_modules_/grid/components/containers/GridRootStyles.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please break it down, it mixes too many unrelated changes that can deliver value on their own.
Please break it down, it mixes too many unrelated changes that can deliver value on their own. |
Oops, I was on my phone, I didn't meant to close it, I have pressed the wrong button. I was hoping you would. The last commit looks good, I had something similar in mind for fixing it 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are close :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to solve the last regressions we had on HEAD. I can make a release once it's merged.
Add customisation on 3 components
Fixes #895