Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPro] Support pinned rows editing #8921

Merged
merged 6 commits into from May 16, 2023
Merged

[DataGridPro] Support pinned rows editing #8921

merged 6 commits into from May 16, 2023

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented May 8, 2023 •
edited

@cherniavskii cherniavskii added component: data grid This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user feature: Row pinning Related to the data grid Row pinning feature enhancement This is not a bug, nor a new feature labels May 8, 2023
@mui-bot
Copy link

mui-bot commented May 8, 2023 •
edited

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-8921--material-ui-x.netlify.app/

Updated pages

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 668.4 1,261.7 1,261.7 955.24 205.273
Sort 100k rows ms 760.4 1,454.9 1,213.9 1,137.3 224.063
Select 100k rows ms 275.2 412.7 293.2 321.66 49.485
Deselect 100k rows ms 188.2 376.3 255.6 277.4 80.475

Generated by 🚫 dangerJS against 12a0e4e

@cherniavskii cherniavskii marked this pull request as ready for review May 10, 2023 20:05
MBilalShafi
MBilalShafi approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition 🎉

@cherniavskii cherniavskii merged commit fc0c36b into mui:master May 16, 2023
17 checks passed
@cherniavskii cherniavskii deleted the pinnedRows-editing branch May 16, 2023 10:53
@MBilalShafi MBilalShafi mentioned this pull request Jun 9, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

@m4theushw m4theushw Awaiting requested review from m4theushw

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature feature: Row pinning Related to the data grid Row pinning feature plan: Pro Impact at least one Pro user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Support pinned rows editing
3 participants
@cherniavskii @mui-bot @MBilalShafi