Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Add missing keys in Hebrew (he-IL) locale #8943

Merged
merged 2 commits into from May 13, 2023
Merged

[l10n] Add missing keys in Hebrew (he-IL) locale #8943

merged 2 commits into from May 13, 2023

Conversation

yitzchak-schechter
Copy link
Contributor

Adding a translation to:

  1. columnMenuManageColumns
  2. filterPanelRemoveAll

Adding a translation to:
1. columnMenuManageColumns
2. filterPanelRemoveAll

Signed-off-by: Yitzchak Schechter <113264132+Itzik-Tech@users.noreply.github.com>
@mui-bot
Copy link

mui-bot commented May 10, 2023

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running yarn l10n
  • Clean files with yarn prettier.

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-8943--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 599.1 1,190.2 635.4 803.3 217.271
Sort 100k rows ms 612.9 1,323.2 905.6 957.66 226.326
Select 100k rows ms 215.8 400.4 292.8 299.9 77.073
Deselect 100k rows ms 154 300.9 184.5 211.14 57.636

Generated by 🚫 dangerJS against aa49743

@zannager zannager added the l10n localization label May 10, 2023
@oliviertassinari oliviertassinari changed the title Update heIL.ts [l10n] Add missing keys in Hebrew (he-IL) locale May 13, 2023
@oliviertassinari
Copy link
Member

Thanks, missing translations are down to:

  // unpin: 'Unpin',
  // detailPanelToggle: 'Detail panel toggle',
  // aggregationMenuItemHeader: 'Aggregation',
  // aggregationFunctionLabelSum: 'sum',
  // aggregationFunctionLabelAvg: 'avg',
  // aggregationFunctionLabelMin: 'min',
  // aggregationFunctionLabelMax: 'max',
  // aggregationFunctionLabelSize: 'size',

@oliviertassinari oliviertassinari enabled auto-merge (squash) May 13, 2023 11:07
@oliviertassinari oliviertassinari merged commit 2ef454a into mui:master May 13, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants