[DataGrid] Fix footer count not showing on small screens #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
added
bug 🐛
dtassone
reviewed
Jan 22, 2021
dtassone
approved these changes
Jan 22, 2021
oliviertassinari
approved these changes
Jan 22, 2021
DanailH
approved these changes
Jan 22, 2021
oliviertassinari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #847
I've tried the silution proposed in #847 (comment) but there was a problem (when there is no select for rows per page, the caption which we want to show is immediately after the
$spacerand it was hidden).The only viable difference I could find between the two captions, was that the one which is used as label have
id, so I used that information. Honestly, it would have been much easier, if theTablePaginationhad different classes for these two elements.Not sure if this is the best fix, but I am open to other ideas. I was trying to come up with some sibling selector, but I couldn't do it, as the same class is used on both places.
Not sure what's the best way for adding test for this, so please let me know.