New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fields] Select the first section instead of last when clicking right of content #9005
Conversation
Netlify deploy previewNetlify deploy preview: https://deploy-preview-9005--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
Nice one ! For the failing test, I think we are just putting the selection on the last character (which a real person would not do). it('should set meridiem to AM when pressing "a" and a value is provided', () => {
testFieldChange({
format: adapter.formats.fullTime12h,
defaultValue: adapter.date(new Date(2022, 5, 15, 14, 12, 25)),
cursorPosition: 17,
// Press "a"
keyStrokes: [{ value: '02:12 a', expected: '02:12 AM' }],
});
}); Setting the cursor position to 16 should do the trick. Side note, this it('should set meridiem to AM when pressing "a" and a value is provided', () => {
testFieldChange({
// ...other params
selectedSection: 'month',
});
}); That would be nicer, I'll try doing that later on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳 great first PR
Thanks! 🎉 |
It's a strike 🎳 This PR also solve #8945 |
That's a good ROI PR 😆 |
Fixes #8967