[react] Create Hidden component #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
commented
Jun 18, 2024
Comment on lines
+7
to
+23
| const hiddenAtomics = generateAtomics(({ theme }) => { | ||
| const conditions = {}; | ||
|
|
||
| for (let i = 0; i < theme.breakpoints.keys.length; i += 1) { | ||
| const breakpoint = theme.breakpoints.keys[i]; | ||
| conditions[`${theme.breakpoints.keys[i]}Only`] = theme.breakpoints.only(breakpoint); | ||
| conditions[`${theme.breakpoints.keys[i]}Up`] = theme.breakpoints.up(breakpoint); | ||
| conditions[`${theme.breakpoints.keys[i]}Down`] = theme.breakpoints.down(breakpoint); | ||
| } | ||
|
|
||
| return { | ||
| conditions, | ||
| properties: { | ||
| display: ['none'], | ||
| }, | ||
| }; | ||
| }); |
brijeshb42
reviewed
Jun 18, 2024
brijeshb42
reviewed
Jun 18, 2024
siriwatknp
commented
Jun 18, 2024
| @@ -6,5 +6,4 @@ export { generateAtomics, atomics } from './generateAtomics'; | |||
| export { default as css } from './css'; | |||
| export { default as createUseThemeProps } from './createUseThemeProps'; | |||
| export { default as internal_createExtendSxProp } from './createExtendSxProp'; | |||
| export { default as Box } from './Box'; | |||
There was a problem hiding this comment.
@brijeshb42 I have to remove this, otherwise the test fail due to "Cannot find a module ./Box". I believe that Box should be imported from @pigment-css/react/Box right?
github-actions
bot
added
the
PR: out-of-date
DiegoAndai
approved these changes
Jun 18, 2024
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With a flip perspective, I am able to create the Hidden with the same API using the existing
generateAtomicsfn.Instead of declaring
xs, … xlas conditions, I use the prop namexsUp, xsDown, xsOnly, … xlUp, xlDown, xlOnlyas conditions.In the component, it reads the runtime theme to find the breakpoint keys and compose the
displayatomic object:Test
See
packages/pigment-css-react/tests/generateAtomics.test.js