[react] Remove sx transform logic and leverage Emotion unitless #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
changed the title
github-actions
bot
added
the
PR: out-of-date
brijeshb42
reviewed
Jun 19, 2024
|
Why is the lockfile changing so much ? |
…ve-style-function-sx
github-actions
bot
removed
the
PR: out-of-date
I open this PR before updating the package manager in package json. It's fixed now. |
brijeshb42
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #133
I found the comment about
unitlessand tried with@emotion/unitless. I don't see any problem. I am happy to revert the change if you think it should be a separate PR.