Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add GitHub workflows #19

Merged
merged 5 commits into from
Apr 19, 2024
Merged

[core] Add GitHub workflows #19

merged 5 commits into from
Apr 19, 2024

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Apr 17, 2024

I isolated the commits for easier review. The first one just copies the files, while the second one is making the changes. I've altered the CONTRIBUTING.md guide too.

@mnajdova mnajdova added the core Infrastructure work going on behind the scenes label Apr 17, 2024
@@ -0,0 +1,39 @@
name: 'Priority Support: SLA ⏰'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should be here (same with Base UI). Do we provide priority support for X subscribers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering the same, there were few other X related things that I copied over, cc @oliviertassinari?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We sold support on Core for a few customers, I believe, a handful. From their perspective, they need as much Material UI as the advanced components that extends Material UI, they compare us with Kendo UI or Syncfusion that offers the same product coverage.

On the implementation, I believe the plan is to change this issue template to be broader, allow anyone to validate their support key and see what they have access to.

# These runs in our repos are spread evenly throughout the day to avoid hitting rate limits.
# If you change this schedule, consider changing the remaining repositories as well.
# Runs at 12 am, 12 pm
- cron: '0 0,12 * * *'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These run times should be different per repository so we avoid running into API call limits on Github.

Co-authored-by: Michał Dudak <michal.dudak@gmail.com>
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
@mnajdova mnajdova marked this pull request as ready for review April 19, 2024 06:48
@mnajdova mnajdova merged commit 2a82094 into mui:master Apr 19, 2024
6 checks passed
```

After this, you can run one of the applications located in the `/apps` directory, by following their `README.md` files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we delete all of this and instead apply https://github.com/mui/base-ui/blob/master/CONTRIBUTING.md?plain=1? It doesn't feel like we have bandwidth to maintain a hybrid version of this file, well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants