Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Create Circle CI config #4

Merged
merged 17 commits into from
Apr 15, 2024
Merged

[core] Create Circle CI config #4

merged 17 commits into from
Apr 15, 2024

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Apr 12, 2024 •
edited
Loading

WIP. I am testing the CI checks in mnajdova#1.

I will set up the Circle CI project after this pull request is merged, as we would have the config.yml already on master.

@mnajdova mnajdova marked this pull request as draft April 12, 2024 15:03
@mnajdova mnajdova changed the title [core] Setup Circle CI [core] Create Circle CI config Apr 15, 2024
@mnajdova mnajdova marked this pull request as ready for review April 15, 2024 09:09
michaldudak
michaldudak approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't spot any obvious issues. Let's merge it and try it out.

@mnajdova mnajdova merged commit c532da3 into mui:master Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

@brijeshb42 brijeshb42 Awaiting requested review from brijeshb42

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mnajdova @michaldudak @oliviertassinari