Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Cleanup #63

Merged
merged 4 commits into from
May 9, 2024
Merged

[core] Cleanup #63

merged 4 commits into from
May 9, 2024

Conversation

brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 added the core Infrastructure work going on behind the scenes label May 9, 2024
@brijeshb42 brijeshb42 changed the title Cleanup [core] Cleanup May 9, 2024
@brijeshb42 brijeshb42 requested a review from mnajdova May 9, 2024 13:01
mnajdova
mnajdova approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes makes sense. I would like to stress attention that we do want to have some regressions test on Pigment CSS, I know we are testing the utils via unit tests, but eventually we should add regressions tests, as it's the only way to have a real use-case scenario being tested with the library. This is the main reason why I didn't drop them so far, but considering how different the project is, I think it makes sense to do them from scratch.

@brijeshb42
Copy link
Contributor Author

Yes. I agree with having regression tests and I also had a similar thought of having it from scratch. That's why I removed those. There is some more cleanup to be done related to unit testing so that we can get rid of babel deps. But that will be a separate PR.

@brijeshb42 brijeshb42 merged commit 3257fcc into mui:master May 9, 2024
11 checks passed
@brijeshb42 brijeshb42 added dependencies Update of dependencies and removed dependencies Update of dependencies labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brijeshb42 @mnajdova