fixed bug that submitted form on dropdown click

muicss · May 14, 2015 · 008b637 · 008b637
1 parent 34df261
commit 008b637
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # MUI Changelog
 
+## 0.1.2 -
+
+* Fixed bug to prevent form submission on dropdown click
+
 ## 0.1.1 - May 10, 2015
 
 * Removed bower dependencies

diff --git a/dist/js/mui.js b/dist/js/mui.js
@@ -90,10 +90,12 @@ function clickHandler(ev) {
   // exit if toggle button is disabled
   if (toggleEl.getAttribute('disabled') !== null) return;
 
-  // let event bubble before toggling dropdown
-  setTimeout(function() {
-    if (!ev.defaultPrevented) toggleDropdown(toggleEl);
-  }, 0);
+  // prevent form submission
+  ev.preventDefault();
+  ev.stopPropagation();
+
+  // toggle dropdown
+  toggleDropdown(toggleEl);
 }